Rubocop

[michaelachrisco]

Closes #24

[michaelachrisco]

It might be more productive to rubocop each file rather than the entire project but Ill let you guys decide. Let me know if this works out for you.

Also #25 should tell me if these changes are breaking for ruby 1.9 since I ran this rubocop on 2.2

[chrismetcalf]

This one is going to take me a bit of time to read through. Looking now. :)

[michaelachrisco]

Now that you have travis, I can break it down file by file if need be and make sure each passes for different versions of ruby. I know that some of these changes will break older versions of ruby. I also added in thoughtbots rubocop config but feel free to browse through and remove/add any suggestions.

[chrismetcalf]

@michaelachrisco Thanks, I looked through it and the changes all look pretty reasonable. Did they pass the tests locally? I didn't see anything that'd introduce breaking changes in my code read.

Also, I am now embarrassed by my Rubies 😞

@housepage Can I get your 👀 on this too?

[michaelachrisco]

Locally all the tests pass. But travis should take care of anything I am missing. 👍

[chrismetcalf]

Woot.

[michaelachrisco]

Looks like 2.2 might have some issues. I would suggest not merging until #27 is passing.

[housepage]

@chrismetcalf Giving this a look now. @michaelachrisco Can you can get this branch back in an automergeable state please?

[housepage]

Everything looks good to me. Did the rebase, added rubocop as a dependency, added a rake task, and added it to the travis build in #30. Thanks so much for your contribution @michaelachrisco!