Adding Rubocop. Moving to use gemspec. Add rubocop to travis run. #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rubocop first pass - 5 offenses left
Closed
|
Cool thanks. I was in the middle of a meeting so this saves me a bit of work 😄 |
housepage
force-pushed
the
michaelachrisco/rubocop_best_practice
branch
from
adc7ee7 to
448d0a8
Compare
housepage
added a commit
that referenced
this pull request
Jun 11, 2015
…tice Adding Rubocop. Moving to use gemspec. Add rubocop to travis run.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed to do a rebase of @michaelachrisco work in #26 for it to mergeable. Also added rubocop run to travis build.