[SofaCUDA,SofaDistanceGrid] Move DistanceGrid CUDA files in a SofaDistanceGrid extension #4878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alxbilger
force-pushed
the
distancegridcuda
branch
from
ea41c6f
to
17a804c
Compare
alxbilger
force-pushed
the
distancegridcuda
branch
from
17a804c
to
4ee5f02
Compare
|
|
||
|
|
||
| namespace sofa::gpu::cuda | ||
| #if defined(__cplusplus) && CUDA_VERSION < 2000 |
There was a problem hiding this comment.
I also would like to know. NVCC is still a mystery for me...
alxbilger
added
the
pr: status to review
|
Compilation issue on Windows. Modernize the CUDA Cmake before this PR. This plugin adds C source file, making it harder than other reordering done before. Problem arise from the fact that CMake passes compile option to NVCC that the compiler doesn't understand. |
fredroy
force-pushed
the
distancegridcuda
branch
from
aa5e7b0
to
2930512
Compare
alxbilger
force-pushed
the
distancegridcuda
branch
from
2930512
to
c0dad15
Compare
|
[ci-build][with-all-tests] |
fredroy
force-pushed
the
distancegridcuda
branch
from
cccf508
to
4425187
Compare
fredroy
approved these changes
Sep 26, 2024
|
[ci-build][with-all-tests][force-full-build] |
1 similar comment
|
[ci-build][with-all-tests][force-full-build] |
alxbilger
force-pushed
the
distancegridcuda
branch
from
4425187
to
78151f1
Compare
fredroy
force-pushed
the
distancegridcuda
branch
from
78151f1
to
73a67ae
Compare
|
[ci-build][with-all-tests][force-full-build] |
fredroy
force-pushed
the
distancegridcuda
branch
from
73a67ae
to
bf49423
Compare
|
[ci-build][with-all-tests][force-full-build] |
fredroy
removed
the
pr: status to review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if