Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support strings in tabs items #37

Merged
merged 1 commit into from
Sep 10, 2024
Merged

feat: support strings in tabs items #37

merged 1 commit into from
Sep 10, 2024

Conversation

nickfrosty
Copy link
Collaborator

added support for passing a string value for the items inside the Tabs component

this will allow passing a comma-separated list of the tab labels within dev content files

note: this is to support fixing the render errors with several open issues in the dev-content repo: solana-foundation/developer-content#455
these issues are being caused by crowdin altering the content files in an odd way, specifically when an MDX component has an attribute with an array value, crowdin prepends a \ in front of the components opening tag. breaking the parser....

Copy link

vercel bot commented Sep 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
solana-com ✅ Ready (Inspect) Visit Preview Sep 10, 2024 3:59pm

Copy link
Collaborator

@catalinred catalinred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Nick!

@nickfrosty nickfrosty merged commit e4b5d56 into main Sep 10, 2024
3 checks passed
@nickfrosty nickfrosty deleted the fix-tabs branch September 10, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants