Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support strings in tabs items #37

Merged
merged 1 commit into from
Sep 10, 2024
Merged

feat: support strings in tabs items #37

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions src/components/shared/MarkdownRenderer/components/MarkdownTabs.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import styles from "./MarkdownTabs.module.scss";

interface MarkdownTabsProps {
children: ReactNode;
items?: string[];
items?: string[] | string;
defaultIndex?: number;
groupId?: string;
persist?: boolean;
Expand All @@ -27,7 +27,12 @@ export function MarkdownTabs({
persist = false,
...props
}: MarkdownTabsProps) {
const values = useMemo(() => items.map((item) => toValue(item)), [items]);
const labels: string[] = useMemo(() => {
if (typeof items == "string")
return items.split(",").map((item) => item.trim());
else return items;
}, []);
const values = useMemo(() => labels.map((item) => toValue(item)), [labels]);
const [value, setValue] = useState(values[defaultIndex]);

useLayoutEffect(() => {
Expand Down Expand Up @@ -75,7 +80,7 @@ export function MarkdownTabs({
v === value ? styles["active"] : ""
}`}
>
{items[i]}
{labels[i]}
</TabsPrimitive.Trigger>
))}
</TabsPrimitive.List>
Expand Down
Loading