release: Bump tlv-account-resolution and dependents #5367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buffalojoec
reviewed
Sep 26, 2023
Comment on lines
13
to
27
|
|
||
| [dependencies] | ||
| solana-program = "1.16.13" | ||
| spl-token-2022 = { version = "0.8", path = "../../token/program-2022" } | ||
| spl-token-2022 = { version = "0.9", path = "../../token/program-2022" } | ||
| spl-token-metadata-interface = { version = "0.2.0", path = "../interface" } | ||
| spl-type-length-value = { version = "0.3.0" , path = "../../libraries/type-length-value" } | ||
| spl-pod = { version = "0.1.0", path = "../../libraries/pod" } | ||
|
|
||
| [dev-dependencies] | ||
| solana-program-test = "1.16.13" | ||
| solana-sdk = "1.16.13" | ||
| spl-token-client = { version = "0.6", path = "../../token/client" } | ||
| spl-token-client = { version = "0.7", path = "../../token/client" } | ||
| test-case = "3.2" | ||
|
|
||
| [lib] |
There was a problem hiding this comment.
Do we want to bump the minor version of the Token Metadata example considering these dependency changes?
There was a problem hiding this comment.
I guess I don't see you doing that in a few other libs, maybe not necessary? Like stake-pool and the swap/upgrade/wrap programs.
There was a problem hiding this comment.
Yeah, pretty much I want to publish everything necessary for a new token-2022 to be used in the monorepo, which is only the core crates. We can bump all the other programs at some other point and release them separately
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We want to use a new version of spl-token-2022, but its version on master depends on spl-tlv-account-resolution, which made a breaking change to support deriving PDAs from account data.
Solution
Bump tlv-account-resolution and everything that depends on it to a new minor version. The idea was to do a minor version bump on things that we want to release, and things that would break because of the change.