token-js: refactor metadata pointer tests #6290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
This was referenced Feb 23, 2024
buffalojoec
force-pushed
the
02-23-token-js_refactor_metadata_pointer_tests
branch
from
c7d1f29 to
98be555
Compare
Merged
Merge activity
|
buffalojoec
deleted the
02-23-token-js_refactor_metadata_pointer_tests
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
MetadataPointertests are a little bit difficult to follow, so this changerefactors them to be a bit more legible, so onlookers can see what's going on
and learn how to use the
MetadataPointerinstructions & state from observingthe tests.