Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

token-js: add GroupPointer extension #6291

Merged
merged 1 commit into from
Feb 24, 2024
Merged

token-js: add GroupPointer extension #6291

merged 1 commit into from
Feb 24, 2024

Conversation

buffalojoec
Copy link
Contributor

As mentioned in #6175, the GroupPointer extension is live on Token-2022
mainnet-beta, but it's not currently supported in the @solana/spl-token.

This change adds that support!

@buffalojoec Graphite App
Copy link
Contributor Author

buffalojoec commented Feb 23, 2024 •
edited
Loading

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

This was referenced Feb 23, 2024
Merged
Merged
@buffalojoec buffalojoec force-pushed the 02-23-token-js_refactor_metadata_pointer_tests branch from c7d1f29 to 98be555 Compare February 23, 2024 21:28
@buffalojoec buffalojoec force-pushed the 02-23-token-js_add_GroupPointer_extension branch from fdd137c to aab253d Compare February 23, 2024 21:28
@buffalojoec buffalojoec mentioned this pull request Feb 23, 2024
Merged
joncinque
joncinque previously approved these changes Feb 23, 2024
View reviewed changes
Copy link
Contributor

@joncinque joncinque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one little micro-nit. Also, as follow-up work, can you add the group pointer and group member pointer authorities in instructions/setAuthority.ts?

point

token/js/src/extensions/groupPointer/instructions.ts Outdated Show resolved Hide resolved
@buffalojoec
Copy link
Contributor Author

Just one little micro-nit. Also, as follow-up work, can you add the group pointer and group member pointer authorities in instructions/setAuthority.ts?

Yep, I'll add to the stack!

@buffalojoec buffalojoec force-pushed the 02-23-token-js_add_GroupPointer_extension branch from aab253d to 47e66c7 Compare February 24, 2024 15:02
@buffalojoec buffalojoec mentioned this pull request Feb 24, 2024
Merged
@buffalojoec Graphite App
Copy link
Contributor Author

buffalojoec commented Feb 24, 2024 •
edited
Loading

Merge activity

  • Feb 24, 10:24 AM EST: @buffalojoec started a stack merge that includes this pull request via Graphite.
  • Feb 24, 10:25 AM EST: Graphite rebased this pull request as part of a merge.
  • Feb 24, 10:25 AM EST: @buffalojoec merged this pull request with Graphite.

Base automatically changed from 02-23-token-js_refactor_metadata_pointer_tests to master February 24, 2024 15:24
@buffalojoec buffalojoec force-pushed the 02-23-token-js_add_GroupPointer_extension branch from 47e66c7 to 40555df Compare February 24, 2024 15:24
@mergify mergify bot dismissed joncinque’s stale review February 24, 2024 15:24

Pull request has been modified.

@buffalojoec buffalojoec merged commit e3262a9 into master Feb 24, 2024
17 checks passed
@buffalojoec buffalojoec deleted the 02-23-token-js_add_GroupPointer_extension branch February 24, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joncinque joncinque joncinque left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@buffalojoec @joncinque