perf: Switch LensVM to wasmtime runtime

[AndrewSisley]

Relevant issue(s)

Resolves #2029

Description

Switches LensVM to the wasmtime runtime.

Should be a fair bit faster than wazero, and supports all the important build targets. Also doesn't suffer from tetratelabs/wazero#1818

Note on wasmtime-go:

This Go library uses CGO to consume the C API of the Wasmtime project which is written in Rust. Precompiled binaries of Wasmtime are checked into this repository on tagged releases so you won't have to install Wasmtime locally, but it means that this project only works on Linux x86_64, macOS x86_64 , and Windows x86_64 currently. Building on other platforms will need to arrange to build Wasmtime and use CGO_* env vars to compile correctly.

This is different to wazero, which as a pure Go project supports pretty much anything Go does without messing about.

Note: I had to change a test module, the new Lens version has closed a memory leak upon which the defra test module was relying on.

Todo

• Have a chat about cross compilation issues

How has this been tested?

Specify the platform(s) on which this was tested:

• Debian Linux
• Mac arm64
• Windows

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (177ca01) 74.03% compared to head (a32a92c) 73.78%.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #2030      +/-   ##
===========================================
- Coverage    74.03%   73.78%   -0.25%     
===========================================
  Files          248      248              
  Lines        24801    24801              
===========================================
- Hits         18359    18298      -61     
- Misses        5189     5236      +47     
- Partials      1253     1267      +14     

Flag	Coverage Δ
all-tests	73.78% <100.00%> (-0.25%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
lens/registry.go	79.51% <100.00%> (ø)

... and 7 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 177ca01...a32a92c. Read the comment docs.

[fredcarle]

LGTM

[shahzadlone]

Comment from discord after passing make test:lens on windows:

Perhaps can add in README:

• Enable CGO
• Need GCC (for windows need mingw, i.e. choco install mingw)

[jsimnz]

@shahzadlone

CGO is needed regardless with this wasmtime integration. Is there something more specific you are referring to with the windows build?

[shahzadlone]

@shahzadlone

CGO is needed regardless with this wasmtime integration. Is there something more specific you are referring to with the windows build?

Yea so normally on linux I have never had to worry about enabling cgo manually.

However on windows, by default cgo is disabled. So it needs to be enabled and Inaddition the mingw dependency is needed for gcc tool chain.

Would be nice to document this in build requirements in README explicitly for windows.

[fredcarle]

The need for cgo really sucks. Too bad Wasmer isn't more actively maintained.

[jsimnz]

The need for cgo really sucks. Too bad Wasmer isn't more actively maintained.

CGO applied to wasmer as well. Unless you mean wazero. But yes, not a fan of it in general, as it does some wonky things to the go runtime.

It shouldn't be hard to get wazero back to a place we can use it with the enumerator work. Then we can add a option as to which build users want. Wasmtime and speed, but with cgo vs wazero and slower, but no cgo

[fredcarle]

I think I mixed the two yes 🙃

[islamaliev]

LGTM