Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(i): Server dump fails #2374

Merged
merged 2 commits into from
Mar 5, 2024
Merged

Conversation

nasdf
Copy link
Member

@nasdf nasdf commented Mar 5, 2024

Relevant issue(s)

Resolves #2373

Description

This PR fixes an issue that caused the server dump command to use the in memory store incorrectly and fail.

Tasks

  • I made sure the code is well commented, particularly hard-to-understand areas.
  • I made sure the repository-held documentation is changed accordingly.
  • I made sure the pull request title adheres to the conventional commit style (the subset used in the project can be found in tools/configs/chglog/config.yml).
  • I made sure to discuss its limitations such as threats to validity, vulnerability to mistake and misuse, robustness to invalidation of assumptions, resource requirements, ...

How has this been tested?

manually defradb server-dump

Specify the platform(s) on which this was tested:

  • MacOS

@nasdf nasdf added the bug Something isn't working label Mar 5, 2024
@nasdf nasdf added this to the DefraDB v0.10 milestone Mar 5, 2024
@nasdf nasdf self-assigned this Mar 5, 2024
Copy link

codecov bot commented Mar 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.00%. Comparing base (a6e886e) to head (cd12325).

❗ Current head cd12325 differs from pull request most recent head 4d96ad1. Consider uploading reports for the commit 4d96ad1 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2374      +/-   ##
===========================================
- Coverage    75.07%   75.00%   -0.07%     
===========================================
  Files          266      266              
  Lines        25855    25854       -1     
===========================================
- Hits         19409    19391      -18     
- Misses        5141     5156      +15     
- Partials      1305     1307       +2     
Flag Coverage Δ
all-tests 75.00% <ø> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
cli/server_dump.go 19.23% <ø> (+0.71%) ⬆️

... and 8 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6e886e...4d96ad1. Read the comment docs.

Copy link
Collaborator

@fredcarle fredcarle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@shahzadlone shahzadlone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. assuming was tested through cli :P

@nasdf nasdf merged commit 002f522 into sourcenetwork:develop Mar 5, 2024
27 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Server dump command fails
3 participants