fix: temporarily disable solidity tests #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iajoiner
force-pushed
the
bump-foundry
branch
2 times, most recently
from
a822bd9
to
96992bc
Compare
iajoiner
force-pushed
the
bump-foundry
branch
from
96992bc
to
cd52beb
Compare
iajoiner
approved these changes
Sep 18, 2024
|
🎉 This PR is included in version 0.22.6 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
iajoiner
added a commit
that referenced
this pull request
Oct 1, 2024
# Rationale for this change #166 disabled solidity tests due to instability in the forge repo. # What changes are included in this PR? * Added a new `ForgeScript` type to enable testing. This type only depends on the published version of `alloy-sol-types`, which should be stable enough for our purposes. * Refactored the existing tests to use this instead. * Updated the CI to run these tests. # Are these changes tested? Yes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
See alloy-rs/alloy#1307 and foundry-rs/foundry#8895 for the background.
What changes are included in this PR?
Disable solidity tests
Are these changes tested?
Existing tests do pass