-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
POC: Circular annulus support in Imviz #2164
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2164 +/- ##
==========================================
- Coverage 91.50% 91.46% -0.04%
==========================================
Files 147 147
Lines 16142 16151 +9
==========================================
+ Hits 14771 14773 +2
- Misses 1371 1378 +7
☔ View full report in Codecov by Sentry. |
but still need to write tests. [ci skip] [rtd skip]
[ci skip] [rtd skip]
[ci skip]
Looks nice! |
Yes, it is currently hardcoded to 5. I am not sure how to make it fancier without writing a full-fledged plugin. I am hoping it won't matter when we can edit compound subset in the future. |
After the discussions on 2023-05-10, people are only interested in using Import Data to load region files (#2188), not the other two features (click to center and annulus stamping). |
Description
This pull request is to add circular annulus support so we can simplify UI for Simple Aperture Photometry plugin.
This needs:
CircleAnnulusPixelRegion
glue-viz/glue-astronomy#90This unblocks:
Change log entry
CHANGES.rst
? If you want to avoid merge conflicts,list the proposed change log here for review and add to
CHANGES.rst
before merge. If no, maintainershould add a
no-changelog-entry-needed
label.Checklist for package maintainer(s)
This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.
trivial
label.