Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POC: Circular annulus support in Imviz #2164

Closed
wants to merge 6 commits into from

Conversation

pllim
Copy link
Contributor

@pllim pllim commented Apr 24, 2023

Description

This pull request is to add circular annulus support so we can simplify UI for Simple Aperture Photometry plugin.

This needs:

This unblocks:

Screenshot 2023-04-25 213154

Screenshot 2023-04-26 121539

Screenshot 2023-04-26 135252

Change log entry

  • Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
    list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
    should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)? 🐱

@pllim pllim added this to the 3.5 milestone Apr 24, 2023
@github-actions github-actions bot added the documentation Explanation of code and concepts label Apr 24, 2023
@codecov
Copy link

codecov bot commented Apr 24, 2023

Codecov Report

Patch coverage: 22.22% and project coverage change: -0.04 ⚠️

Comparison is base (ae82864) 91.50% compared to head (7a24bb5) 91.46%.

❗ Current head 7a24bb5 differs from pull request most recent head c544dba. Consider uploading reports for the commit c544dba to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2164      +/-   ##
==========================================
- Coverage   91.50%   91.46%   -0.04%     
==========================================
  Files         147      147              
  Lines       16142    16151       +9     
==========================================
+ Hits        14771    14773       +2     
- Misses       1371     1378       +7     
Impacted Files Coverage Δ
jdaviz/core/region_translators.py 92.59% <22.22%> (-6.40%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

but still need to write tests.
[ci skip] [rtd skip]
@pllim pllim added feature Feature request imviz labels Apr 26, 2023
@camipacifici
Copy link
Contributor

Looks nice!
I like very much the idea of adding an explicit button to move subsets. Maybe the icon can differ from the zoom icon? @Jenneh might have ideas here.
I am not sure I understand the behavior of the last button. Is the width always fixed to 5 pixels or is some dragging required?

@pllim
Copy link
Contributor Author

pllim commented Apr 26, 2023

Is the width always fixed to 5 pixels

Yes, it is currently hardcoded to 5. I am not sure how to make it fancier without writing a full-fledged plugin. I am hoping it won't matter when we can edit compound subset in the future.

@pllim
Copy link
Contributor Author

pllim commented May 10, 2023

After the discussions on 2023-05-10, people are only interested in using Import Data to load region files (#2188), not the other two features (click to center and annulus stamping).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Explanation of code and concepts feature Feature request imviz
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants