Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for holidays in Nigeria #10

Merged
merged 6 commits into from
Jan 31, 2024

Conversation

cybernerdie
Copy link
Contributor

@cybernerdie cybernerdie commented Jan 17, 2024

Changes Introduced:

Introduction of a new Nigeria class to handle accurate calculations for Nigeria public holidays.

Overview:

This pull request introduces a dedicated Nigeria class within the Spatie\Holidays\Countries namespace. The class is designed to handle precise calculations for public holidays in Nigeria. This addition ensures that developers have access to accurate dates for both fixed and variable holidays specific to Nigeria.

Correlation Check:

Reviewers can confirm the correlation of the generated holidays by comparing them with the official holidays listed on here.

return array_merge([
'New Year\'s Day' => "01-01",
'Worker\'s Day' => "05-01",
'Children\'s Day' => "05-27",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this an official public holiday? I don't find it here: https://publicholidays.africa/nigeria/2024-dates/

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it's not regarded as an official holiday, i'll remove it @Nielsvanpach

Copy link
Member

@Nielsvanpach Nielsvanpach Jan 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There also seem to be official Muslim holidays on the list. I'm not aware of the rules in Nigeria on this? Is this a public holiday for everyone in the whole country?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The muslim holidays are for everyone but the exact calculation of these holidays involves the sighting of the moon, and it can vary depending on different interpretations within the Islamic community. @Nielsvanpach

@yungifez
Copy link

Could you add armed forces remembrance day?

@cybernerdie
Copy link
Contributor Author

Could you add armed forces remembrance day?

I don't think the armed forces Remembrance Day is regarded as a public holiday in Nigeria, as much as it is celebrated, everybody still get to go about their day's work

@yungifez
Copy link

Hmm that's interesting

Thanks for the clarification

@yungifez
Copy link

What about labour day?

@cybernerdie
Copy link
Contributor Author

What about labour day?

It's same as workers day

@yungifez
Copy link

I'm sorry I missed that

Great job

@Nielsvanpach
Copy link
Member

Could you rebase this branch, so the tests will run?

@cybernerdie
Copy link
Contributor Author

just did that @Nielsvanpach

@Nielsvanpach
Copy link
Member

I'll leave this PR open until we have a proper solution for Islamic holidays.

@Nielsvanpach Nielsvanpach merged commit e30a34d into spatie:main Jan 31, 2024
7 of 8 checks passed
@Nielsvanpach
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants