Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for holidays in Nigeria #10

Merged
merged 6 commits into from
Jan 31, 2024
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 39 additions & 0 deletions src/Countries/Nigeria.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
<?php

namespace Spatie\Holidays\Countries;

use Carbon\CarbonImmutable;

class Nigeria extends Country
{
public function countryCode(): string
{
return 'ng';
}

/** @return array<string, CarbonImmutable> */
protected function allHolidays(int $year): array
{
return array_merge([
'New Year\'s Day' => "01-01",
'Worker\'s Day' => "05-01",
'Children\'s Day' => "05-27",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this an official public holiday? I don't find it here: https://publicholidays.africa/nigeria/2024-dates/

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it's not regarded as an official holiday, i'll remove it @Nielsvanpach

Copy link
Member

@Nielsvanpach Nielsvanpach Jan 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There also seem to be official Muslim holidays on the list. I'm not aware of the rules in Nigeria on this? Is this a public holiday for everyone in the whole country?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The muslim holidays are for everyone but the exact calculation of these holidays involves the sighting of the moon, and it can vary depending on different interpretations within the Islamic community. @Nielsvanpach

'Democracy Day' => "06-12",
'Independence Day' => "10-01",
'Christmas Day' => "12-25",
'Boxing Day' => "12-26",
], $this->variableHolidays($year));
}

/** @return array<string, CarbonImmutable> */
protected function variableHolidays(int $year): array
{
$easter = CarbonImmutable::createFromTimestamp(easter_date($year))
->setTimezone('Africa/Lagos');
Nielsvanpach marked this conversation as resolved.
Show resolved Hide resolved

return [
'Good Friday' => $easter->subDay(2),
'Easter Monday' => $easter->addDay(1),
];
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
[
{
"name": "New Year's Day",
"date": "2024-01-01"
},
{
"name": "Good Friday",
"date": "2024-03-29"
},
{
"name": "Easter Monday",
"date": "2024-04-01"
},
{
"name": "Worker's Day",
"date": "2024-05-01"
},
{
"name": "Children's Day",
"date": "2024-05-27"
},
{
"name": "Democracy Day",
"date": "2024-06-12"
},
{
"name": "Independence Day",
"date": "2024-10-01"
},
{
"name": "Christmas Day",
"date": "2024-12-25"
},
{
"name": "Boxing Day",
"date": "2024-12-26"
}
]
18 changes: 18 additions & 0 deletions tests/Countries/NigeriaTest.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
<?php

namespace Spatie\Holidays\Tests\Countries;

use Carbon\CarbonImmutable;
use Spatie\Holidays\Holidays;

it('can calculate nigerian holidays', function () {
CarbonImmutable::setTestNowAndTimezone('2024-01-01');

$holidays = Holidays::for(country: 'ng')->get();

expect($holidays)
->toBeArray()
->not()->toBeEmpty();

expect(formatDates($holidays))->toMatchSnapshot();
});