Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Slovenian language second PR after rebase problem #139

Merged
merged 1 commit into from
Jan 31, 2024

Conversation

juref
Copy link
Contributor

@juref juref commented Jan 19, 2024

Contributing a new country ?

  • [yes] Have you checked to ensure there aren't other open Pull Requests for the same country?
  1. Create a new class in the Countries directory. It should extend the Country class.
  2. Add a test for the new country in the tests directory.
  3. Run the tests so a snapshot gets created.
  4. Verify the result in the newly created snapshot is correct.

@Nielsvanpach
Copy link
Member

PR looks good! I'll wait for some approvals on the generated results before merging.

@juref juref changed the title Support for Slovenian langage second PR after rebase problem Support for Slovenian language second PR after rebase problem Jan 20, 2024
@Nielsvanpach
Copy link
Member

If applicable, I've added support for multi language: #177

@juref
Copy link
Contributor Author

juref commented Jan 24, 2024

Hey, that's great, thanks! I wanted to do PR with this feature, but unfortunately I was admitted to the hospital after an emergency. All well now!

@Nielsvanpach Nielsvanpach merged commit adf73ed into spatie:main Jan 31, 2024
8 checks passed
@Nielsvanpach
Copy link
Member

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants