-
-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for multi languages #177
Conversation
not using this for country and year either
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Thank you for this addition. This will help certainly! However i have one question: The current solution with language works via the 'magic' method but not if you would create the Country Object as you would do in the current README. Lines 119 to 148 in faf22be
This might be because holidays/src/Countries/Country.php Line 44 in faf22be
does not accept named parameters. Are you open to accept named parameter in that method and drop Or is the construction of holidays via the magic method the standard? |
I'm not sure I understand what you mean. Could you add a PR with a failing test? I've included a test on how to use this with named params: |
No description provided.