Remove ExitWhenReady field #248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 2, 2025
keeganwitt
approved these changes
Feb 2, 2025
faisal-memon
approved these changes
Feb 2, 2025
Per spiffe#243 (comment) the -exitWhenReady flag and corresponding ExitWhenReady option were never in a released version. So this obsolete, now-unused field can be deleted without backwards compatibility impact. Remove the reference from the README too. Signed-off-by: Craig Ringer <[email protected]>
ringerc
force-pushed
the
remove-exitwhenready
branch
from
198dbf6 to
c7c032f
Compare
|
@faisal-memon Done, and README updated per comment above. It's not hard for me to rebase the other one onto this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per #243 (comment) the -exitWhenReady flag and corresponding ExitWhenReady option were never in a released version. So this obsolete, now-unused field can be deleted without backwards compatibility impact.
The separate PR #243 updates the docs to remove reference to the CLI argument -exitWhenReady.