Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ExitWhenReady field #248

Merged
merged 2 commits into from
Feb 4, 2025
Merged

Remove ExitWhenReady field #248

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c7c032f
Remove ExitWhenReady field
ringerc Feb 2, 2025
f07bcbb
Merge branch 'main' into remove-exitwhenready
faisal-memon Feb 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,6 @@ The SPIFFE Helper is a simple utility for fetching X.509 SVID certificates from

If `-config` is not specified, the default value `helper.conf` is assumed.

The flag `-exitWhenReady` is also supported.

## Configuration
The configuration file is an [HCL](https://github.com/hashicorp/hcl) formatted file that defines the following configurations:

Expand Down
3 changes: 0 additions & 3 deletions pkg/sidecar/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,6 @@ type Config struct {
// The directory name to store the x509s and/or JWTs.
CertDir string

// If true, fetches x509 certificate and then exit(0).
ExitWhenReady bool

// Permissions to use when writing x509 SVID to disk
CertFileMode fs.FileMode

Expand Down
Loading