feat!: drop Node v14 support #886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EOL 2023-04-30. blocking dependency upgrades
maxbeatty
commented
Jun 26, 2023
| @@ -144,7 +144,6 @@ module.exports = { | |||
| 'unicorn/prefer-dom-node-remove': 'off', // This incorrectly autofixes `remove()` on non-DOM-nodes. | |||
| 'unicorn/prefer-dom-node-text-content': 'off', // The autofixer can be unsafe. | |||
| 'unicorn/prefer-module': 'off', // Not ready for this yet. | |||
| 'unicorn/prefer-node-protocol': 'off', // TODO: Enable once we drop support for Node 14 entirely. | |||
There was a problem hiding this comment.
included in recommended config https://github.com/sindresorhus/eslint-plugin-unicorn/blob/main/docs/rules/prefer-node-protocol.md
|
You'll want to drop Node 19 as well. Example: qunitjs/eslint-plugin-qunit#373 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EOL 2023-04-30. blocking dependency upgrades (like #882 which will address #880)
https://github.com/nodejs/release#end-of-life-releases