Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: drop Node v14 support #886

Merged
merged 1 commit into from
Jun 28, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions .eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,6 @@ module.exports = {
'https://github.com/square/eslint-plugin-square/tree/master/docs/rules/{{name}}.md',
},
],

'unicorn/prefer-node-protocol': 'error', // TODO: Move this to `base` config once we drop support for Node 14 entirely.
},
overrides: [
{
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:
strategy:
matrix:
os: [ ubuntu, windows ]
node-version: [14.x, 16.x, 18.x]
node-version: [16.x, 18.x, 20.x]

steps:
- uses: actions/checkout@v3
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ This plugin contains lint rule definitions and configurations for [ESLint](http:
## Requirements

- [ESLint](https://eslint.org/) `>= 8.18.0`
- [Node.js](https://nodejs.org/) `^14.18.0 || ^16.0.0 || >= 18.0.0`
- [Node.js](https://nodejs.org/) `^16.0.0 || >= 18.0.0`

## Usage

Expand Down
1 change: 0 additions & 1 deletion lib/config/base.js
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,6 @@ module.exports = {
'unicorn/prefer-dom-node-remove': 'off', // This incorrectly autofixes `remove()` on non-DOM-nodes.
'unicorn/prefer-dom-node-text-content': 'off', // The autofixer can be unsafe.
'unicorn/prefer-module': 'off', // Not ready for this yet.
'unicorn/prefer-node-protocol': 'off', // TODO: Enable once we drop support for Node 14 entirely.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'unicorn/prefer-prototype-methods': 'off', // Too noisy for now.
'unicorn/prefer-query-selector': 'off', // The autofixer can be unsafe.
'unicorn/prefer-switch': 'off', // Too aggressive for now.
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@
"eslint": ">= 8.18.0"
},
"engines": {
"node": "^14.18.0 || ^16.0.0 || >= 18.0.0"
"node": "^16.0.0 || >= 18.0.0"
},
"publishConfig": {
"registry": "https://registry.npmjs.org"
Expand Down