Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for stac-fastapi v2.5.x #101

Merged
merged 16 commits into from
Apr 25, 2024

Conversation

jonhealy1
Copy link
Collaborator

@jonhealy1 jonhealy1 commented Apr 22, 2024

Related Issue(s):

Description:

Update for stac-fastapi v2.5.3

PR Checklist:

  • pre-commit hooks pass locally
  • Tests pass (run make test)
  • Documentation has been updated to reflect changes, if applicable, and docs build successfully (run make docs)
  • Changes are added to the CHANGELOG.

@jonhealy1 jonhealy1 marked this pull request as draft April 22, 2024 10:24
@jonhealy1 jonhealy1 marked this pull request as ready for review April 23, 2024 06:40
Copy link
Member

@vincentsarago vincentsarago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

@vincentsarago vincentsarago self-requested a review April 23, 2024 14:51
@vincentsarago

This comment was marked as outdated.

@vincentsarago
Copy link
Member

alright, tests do pass so ✅

Note: tests pass but it's kinda lucky because we add the prefix to the base_url, while it should be something separate.

We don't need to change anything right now but in the future, we should refactor the tests

@vincentsarago
Copy link
Member

all the comments are resolved, we can go ahead an merge 👍

@jonhealy1 jonhealy1 merged commit fcf4935 into stac-utils:main Apr 25, 2024
7 checks passed
@jonhealy1 jonhealy1 deleted the stac-fastapi-v2.5.2-update branch April 25, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants