Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feature): remove the deprecated Context Extension #138

Merged

Conversation

vincentsarago
Copy link
Member

@vincentsarago vincentsarago commented Apr 4, 2024

ref: radiantearth/stac-api-spec#396

The context extension is deprecated and has been replaced by OGC Feature API NumberMatched NumberReturned attributes

cc @thomas-maschler @gadomski

@codecov-commenter
Copy link

codecov-commenter commented Apr 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (main@c03272e). Click here to learn what that means.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #138   +/-   ##
=======================================
  Coverage        ?   96.71%           
=======================================
  Files           ?       25           
  Lines           ?      579           
  Branches        ?        0           
=======================================
  Hits            ?      560           
  Misses          ?       19           
  Partials        ?        0           
Flag Coverage Δ
unittests 96.71% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gadomski gadomski self-requested a review April 4, 2024 15:18
@vincentsarago
Copy link
Member Author

vincentsarago commented Apr 4, 2024

🤔 I think purely removing it right now might not be the best idea. I'm going to revert this and introduce a Warning about a future deprecation..

☝️ this was already there so I guess removing it makes sense

@@ -1,3 +1,8 @@

3.1.0 (TBD)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can decide later if we want to do a 4.0.0 instead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants