Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove warnings #2139

Merged
merged 20 commits into from
Jan 30, 2024
Merged

Remove warnings #2139

merged 20 commits into from
Jan 30, 2024

Conversation

jorisv
Copy link
Contributor

@jorisv jorisv commented Jan 25, 2024

Remove some warings:

  • Don't use -Wno-self-assign-overloaded on GCC (not implemented)
  • Remove deprecation warning on EIGENPY_DEFINE_STRUCT_ALLOCATOR_SPECIALIZATION
  • Remove useless copy when creating an aligned_vector
  • Don't use derived_const_cast hack for quaternion::uniformRandom since it can't take a block as parameter
  • Use C++11 syntax to define LieGroupGenericTpl copy constructor and assignment operator
  • Add -Wno-maybe-uninitialized with PRAGMA instruction (to false positive on derived_const_cast hack)
  • -DNOMINMAX public
    • Remove it from example and tests
  • Remove conversion warning in unit tests
  • -Wuse-after-free
  • Find a way to manage clangCl options
  • Move CXX_FLAGS_BY_COMPILER_FRONTEND into jrl-cmakemodules
  • Remove -O2 warnings

@jorisv jorisv requested a review from jcarpent January 25, 2024 17:08
@jorisv jorisv self-assigned this Jan 25, 2024
@jorisv
Copy link
Contributor Author

jorisv commented Jan 26, 2024

Finally, I turn -Wno-maybe-uninitialized to PRIVATE. Use should define in there own projects.

@jorisv jorisv marked this pull request as ready for review January 29, 2024 11:01
@jorisv jorisv marked this pull request as draft January 29, 2024 13:51
@jorisv
Copy link
Contributor Author

jorisv commented Jan 29, 2024

Still warning in O2

@jorisv jorisv marked this pull request as ready for review January 29, 2024 14:27
@jcarpent jcarpent merged commit d0daeaa into stack-of-tasks:devel Jan 30, 2024
21 of 22 checks passed
@jorisv jorisv deleted the topic/remove_warnings branch January 30, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants