Skip to content
This repository has been archived by the owner on Dec 4, 2024. It is now read-only.

gh/workflows: pr: add devenv build test #212

Merged
merged 1 commit into from
Oct 3, 2023

Conversation

EmbeddedAndroid
Copy link
Contributor

@EmbeddedAndroid EmbeddedAndroid commented Oct 3, 2023

Summary of Changes

Add a github workflow to build test the devenv containers. This will only trigger when changes are made under the devenv/ directory.

stacks-network/sbtc#211 highlights the need for basic build testing.

Testing

Risks

None, as this is adding a test

How were these changes tested?

Tested actions on fork of repo

What future testing should occur?

We may want to publish built container images to a registry.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@EmbeddedAndroid EmbeddedAndroid added the devenv Development Environment label Oct 3, 2023
@codecov
Copy link

codecov bot commented Oct 3, 2023

Codecov Report

Merging #212 (cca5caa) into main (1ae78d0) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #212   +/-   ##
=======================================
  Coverage   38.56%   38.56%           
=======================================
  Files          44       44           
  Lines        5072     5072           
  Branches       23       23           
=======================================
  Hits         1956     1956           
  Misses       3114     3114           
  Partials        2        2           
Flag Coverage Δ
unittests 89.07% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@CAGS295 CAGS295 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. At some point, we must also check that services reach a 'ready' state.

It bothers me that changes to source code in the services, in most cases, will be the culprit of Devenv failing to build/run. This build job will only run on changes to the devenv dir.

For example, the few times changing romeo/config.rs has broken devnenv due to the config.toml needing to be updated.

Or more extreme cases like #210 have little to do with this repo.

Copy link
Collaborator

@friedger friedger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, if needed we can run the build daily or weekly.

@friedger friedger merged commit 38fdc82 into stacks-archive:main Oct 3, 2023
7 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
devenv Development Environment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants