-
Notifications
You must be signed in to change notification settings - Fork 676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[signer] Add block_proposal_max_age_secs signer configuration to drop old proposals without further processing #5549
Merged
+185
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oposals without processing Signed-off-by: Jacinta Ferrant <[email protected]>
jferrant
force-pushed
the
feat/ignore-old-proposals-signer
branch
from
December 9, 2024 18:53
c0fa28b
to
83a032f
Compare
Signed-off-by: Jacinta Ferrant <[email protected]>
… into feat/ignore-old-proposals-signer
Signed-off-by: Jacinta Ferrant <[email protected]>
…ulti miner tests Signed-off-by: Jacinta Ferrant <[email protected]>
obycode
reviewed
Dec 10, 2024
obycode
previously approved these changes
Dec 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! And thanks for the general improvement to the existing integration tests!!
… proposals Signed-off-by: Jacinta Ferrant <[email protected]>
obycode
reviewed
Dec 10, 2024
Signed-off-by: Jacinta Ferrant <[email protected]>
obycode
approved these changes
Dec 10, 2024
jcnelson
reviewed
Dec 11, 2024
jcnelson
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5513