Expanded lunch #168

Aaaaa501 · 2022-12-23T05:11:51Z

Expanded lunch menu to cover some of jazzmans menue and wood commons

src/components/cards/LunchCard.vue

JosephShepin · 2022-12-23T05:20:21Z

src/components/cards/LunchCard.vue

-    font-weight: bold
-    font-size: .85em
-    text-align: center
+.exLunch


better class name

src/data/miscLunch.json

JosephShepin · 2022-12-23T05:22:53Z

src/components/cards/LunchCard.vue

+      const currTime = currentDate.getHours() * 100 + currentDate.getMinutes();
+      if (currTime < 830) {
+        return true;
+      }


return currTime < 830

also currTime can be renamed to currentTime

not resolved, some logic issue here

src/components/cards/LunchCard.vue

JosephShepin · 2022-12-23T05:30:59Z

src/components/cards/LunchCard.vue

+    isMorning() {
+      const currentDate = new Date();
+      const currTime = currentDate.getHours() * 100 + currentDate.getMinutes();
+      if (currTime < 830) {


add a comment for what 830 means - what time it is

src/components/cards/LunchCard.vue

JosephShepin · 2022-12-23T05:36:59Z

Thanks for submitting this PR, overall it's a great idea and I like the implementation.

JosephShepin · 2022-12-25T18:50:19Z

@Aaaaa501 when it's ready, there is a re-review button. Thanks

JosephShepin · 2022-12-25T18:55:20Z

Aaaaa501 · 2022-12-25T18:57:55Z

Forgot to remove some testing code. Removed it now.

src/components/cards/LunchCard.vue

JosephShepin · 2022-12-25T18:57:04Z

src/components/cards/LunchCard.vue

@@ -49,19 +116,36 @@ export default {
  text-align: center
  margin-bottom: 4px

+.breakfast
+  border-top: var(--color) 1.5px solid
+  padding: 10px 0
 .lunch


Suggested change

.lunch

.lunch

JosephShepin · 2022-12-25T18:57:39Z

src/components/cards/LunchCard.vue

+        faChevronUp,
+      },
+      expandNums: 0,
+      alBreakfast: ['Bacon', 'Sausage', 'Potatoes', 'Eggs'],


better name

JosephShepin · 2022-12-25T19:02:57Z

src/data/miscLunch.json

+                "Protein Box",
+                "Bubble Tea"
+            ],
+            "Coffee and Tea": [


It seems that "sides "and "beverages" accompany cafeteria food, while PWC Jazzmans, Grill and Pizza is a separate location. what is "Coffee and Tea"? is that a location of where to get food?

Is there some way we can make it more clear where these items are? I'm thinking some location tag and icon that's like these items are here. Thoughts on this?

The arrangement ive used is just grouped by order on the school website, but the groups correspond roughly with location. Beverages and Sides are located in the same place as the cafeteria. The grill and pizza is in the wood commons, and the 'Coffee and Tea' category is at Jazzman's. I moved the beverages and sides to the top of the list because it makes more sense in proximity to the rest of the cafeteria foods, but otherwise I think the arrangement makes sense. The locations are common knowledge in my experience, so I'm not sure how useful a location tag would be

Co-authored-by: Joseph Shepin <[email protected]>

JosephShepin

I'm pretty confused by how this is organized. The title says lunch, but breakfast items are shown. Breakfast shouldn't show first because that's data that doesn't change. Then after that there are the lunch items. Opening the dropdown items reveals other items that are not lunch. Drop arrows don't seem like the best option here because the data is not less relevant as you move downward (like the upcoming events) - all the additional items are of equal relevancy more or less. I think it would make more sense to keep the lunch card the way we already have it (showing only lunch), and creating a popup modal where users can see the extended menu instead of having to click through dropdowns. Furthermore it's 11 pm at night and breakfast shouldn't be showing.

also please do not mark conversations as being resolved if they are not. Thank you.

JosephShepin · 2022-12-27T05:22:12Z

src/components/cards/LunchCard.vue

+      const currTime = currentDate.getHours() * 100 + currentDate.getMinutes();
+      if (currTime < 830) {
+        return true;
+      }


not resolved, some logic issue here

aw-0 · 2022-12-30T18:45:03Z

Just coming across this now - love the concept! Would there be potential to rename the entire column to something like "Food" and only display the correct meals at the right times? Like Joey said - maybe breakfast from 7-11, and lunch from 11-3?

We could also add a hyperlink to an additional page that shows an elegant version of the entire menu, and all the options like you currently have @Aaaaa501. But I think having them all there at first glance leaves everything a bit cluttered

Aaaaa501 · 2023-01-04T18:44:59Z

Not sure about the icon I'm using for the button, but otherwise does this work fine?

aw-0 · 2023-01-04T19:02:39Z

That's really sick - great work! I'll leave it to Joey to finish up his code review - the only suggestion I have is maybe adding a title to the modal up here? Like "Full Menu"

JosephShepin · 2023-01-05T01:43:33Z

Thank you for making these changes. I would like to see UI that matches our existing ui framework. I have attached some images of what i'd like to see. You can copy modal code from other places so it matches.

Additionally I think the modal would look a little more refined if the data wasn't all in one column, but spread across multiple columns for easier viewing (it can condense on mobile) - flexbox would be a good choice.

JosephShepin

^^^

JosephShepin · 2023-02-16T18:17:47Z

closing this due to inactivity, feel free to reopen when ready!

Aaaaa501 added 2 commits December 22, 2022 23:01

Create miscLunch.json

f18c066

Update LunchCard.vue

80d3054

JosephShepin added the enhancement/idea label Dec 23, 2022

JosephShepin requested changes Dec 23, 2022

View reviewed changes

Aaaaa501 added 2 commits December 23, 2022 12:32

Update LunchCard.vue

da95052

Update miscLunch.json

4a609c6

Aaaaa501 requested a review from JosephShepin December 25, 2022 18:52

Update LunchCard.vue

63c9ef4

JosephShepin requested changes Dec 25, 2022

View reviewed changes

Aaaaa501 and others added 3 commits December 25, 2022 21:31

Update src/components/cards/LunchCard.vue

aca5cdc

Co-authored-by: Joseph Shepin <[email protected]>

Update LunchCard.vue

39d05be

Update miscLunch.json

2daf39b

Aaaaa501 requested a review from JosephShepin December 26, 2022 16:01

JosephShepin requested changes Dec 27, 2022

View reviewed changes

Aaaaa501 added 3 commits January 4, 2023 12:39

Modal

3724819

Update LunchCard.vue

b110058

Update miscLunch.json

8c695ba

Aaaaa501 requested a review from JosephShepin January 4, 2023 18:43

Aaaaa501 added 3 commits January 4, 2023 13:40

Update LunchCard.vue

e918cfa

Update LunchCard.vue

38affcc

Update LunchCard.vue

f373b53

JosephShepin requested changes Jan 9, 2023

View reviewed changes

aw-0 linked an issue Jan 9, 2023 that may be closed by this pull request

idea: Jazzman's/Grab Lunch Items #140

Open

JosephShepin closed this Feb 16, 2023

aw-0 removed a link to an issue Aug 12, 2023

idea: Jazzman's/Grab Lunch Items #140

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Expanded lunch #168

Expanded lunch #168

Aaaaa501 commented Dec 23, 2022

JosephShepin Dec 23, 2022 •

edited

Loading

JosephShepin Dec 23, 2022

JosephShepin Dec 27, 2022

JosephShepin Dec 23, 2022

JosephShepin commented Dec 23, 2022

JosephShepin commented Dec 25, 2022

JosephShepin commented Dec 25, 2022

Aaaaa501 commented Dec 25, 2022

JosephShepin Dec 25, 2022

JosephShepin Dec 25, 2022

JosephShepin Dec 25, 2022

Aaaaa501 Dec 26, 2022

JosephShepin left a comment •

edited

Loading

JosephShepin Dec 27, 2022

aw-0 commented Dec 30, 2022

Aaaaa501 commented Jan 4, 2023

aw-0 commented Jan 4, 2023

JosephShepin commented Jan 5, 2023

JosephShepin left a comment •

edited

Loading

JosephShepin commented Feb 16, 2023

Expanded lunch #168

Expanded lunch #168

Conversation

Aaaaa501 commented Dec 23, 2022

JosephShepin Dec 23, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

JosephShepin commented Dec 23, 2022

JosephShepin commented Dec 25, 2022

JosephShepin commented Dec 25, 2022

Aaaaa501 commented Dec 25, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

JosephShepin left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

aw-0 commented Dec 30, 2022

Aaaaa501 commented Jan 4, 2023

aw-0 commented Jan 4, 2023

JosephShepin commented Jan 5, 2023

JosephShepin left a comment • edited Loading

Choose a reason for hiding this comment

JosephShepin commented Feb 16, 2023

JosephShepin Dec 23, 2022 •

edited

Loading

JosephShepin left a comment •

edited

Loading

JosephShepin left a comment •

edited

Loading