Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expanded lunch #168
Expanded lunch #168
Changes from 4 commits
f18c066
80d3054
da95052
4a609c6
63c9ef4
aca5cdc
39d05be
2daf39b
3724819
b110058
8c695ba
e918cfa
38affcc
f373b53
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't they sometimes not have all these items? At least when I went they would rotate the bacon and sausage.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now they seem to have all of them
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
better name
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
return currTime < 830
also currTime can be renamed to currentTime
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not resolved, some logic issue here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
better class name
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add a newline before
.arrow-container
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that "sides "and "beverages" accompany cafeteria food, while PWC Jazzmans, Grill and Pizza is a separate location. what is "Coffee and Tea"? is that a location of where to get food?
Is there some way we can make it more clear where these items are? I'm thinking some location tag and icon that's like these items are here. Thoughts on this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The arrangement ive used is just grouped by order on the school website, but the groups correspond roughly with location. Beverages and Sides are located in the same place as the cafeteria. The grill and pizza is in the wood commons, and the 'Coffee and Tea' category is at Jazzman's. I moved the beverages and sides to the top of the list because it makes more sense in proximity to the rest of the cafeteria foods, but otherwise I think the arrangement makes sense. The locations are common knowledge in my experience, so I'm not sure how useful a location tag would be