-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ACM-12676] Added renovate config for konflux #97
[ACM-12676] Added renovate config for konflux #97
Conversation
Signed-off-by: Disaiah Bennett <[email protected]>
/cherry-pick backplane-2.6 |
@dislbenn: once the present PR merges, I will cherry-pick it on top of backplane-2.6 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/cherry-pick backplane-2.5 |
@dislbenn: once the present PR merges, I will cherry-pick it on top of backplane-2.5 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! I have some comments/questions since I was unfamiliar with the settings and took a look at the Renovate docs.
"$schema": "https://docs.renovatebot.com/renovate-schema.json", | ||
"addLabels": ["ok-to-test"], | ||
"rebaseWhen": "behind-base-branch", | ||
"recreateWhen": "never", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this setting is inadvisable:
We recommend that you stick with the default setting for this option. Only change this setting if you really need to.
ref: https://docs.renovatebot.com/configuration-options/#recreatewhen
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After discussing with the team, it seems like the opinion is if we close a PR intentionally then the expected outcome would not to be to reopen the PR. I'm fine with either option; however, I think for now when can test it with the current value that was selected.
Signed-off-by: Disaiah Bennett <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dhaiducek, dislbenn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@dislbenn: new pull request created: #102 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@dislbenn: new pull request created: #103 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Description
Adding
.github/renovate.json
to expand configuration of konflux pull requests.Related Issue
https://issues.redhat.com/browse/ACM-12676
Changes Made
Added
.github/renovate.json
to begin maintainkonflux
pull requests easier.Screenshots (if applicable)
Add screenshots or GIFs that demonstrate the changes visually, if relevant.
Checklist
Additional Notes
Add any additional notes, context, or information that might be helpful for reviewers.
Reviewers
Tag the appropriate reviewers who should review this pull request. To add reviewers, please add the following line:
/cc @reviewer1 @reviewer2
/cc @cameronmwall @ngraham20
Definition of Done