Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ACM-12676] Added renovate config for konflux #97

Merged
merged 2 commits into from
Jul 17, 2024

Conversation

dislbenn
Copy link
Contributor

Description

Adding .github/renovate.json to expand configuration of konflux pull requests.

Related Issue

https://issues.redhat.com/browse/ACM-12676

Changes Made

Added .github/renovate.json to begin maintain konflux pull requests easier.

Screenshots (if applicable)

Add screenshots or GIFs that demonstrate the changes visually, if relevant.

Checklist

  • I have tested the changes locally and they are functioning as expected.
  • I have updated the documentation (if necessary) to reflect the changes.
  • I have added/updated relevant unit tests (if applicable).
  • I have ensured that my code follows the project's coding standards.
  • I have checked for any potential security issues and addressed them.
  • I have added necessary comments to the code, especially in complex or unclear sections.
  • I have rebased my branch on top of the latest main/master branch.

Additional Notes

Add any additional notes, context, or information that might be helpful for reviewers.

Reviewers

Tag the appropriate reviewers who should review this pull request. To add reviewers, please add the following line: /cc @reviewer1 @reviewer2

/cc @cameronmwall @ngraham20

Definition of Done

  • Code is reviewed.
  • Code is tested.
  • Documentation is updated.
  • All checks and tests pass.
  • Approved by at least one reviewer.
  • Merged into the main/master branch.

Signed-off-by: Disaiah Bennett <[email protected]>
@dislbenn
Copy link
Contributor Author

/cherry-pick backplane-2.6

@openshift-cherrypick-robot

@dislbenn: once the present PR merges, I will cherry-pick it on top of backplane-2.6 in a new PR and assign it to you.

In response to this:

/cherry-pick backplane-2.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dislbenn
Copy link
Contributor Author

/cherry-pick backplane-2.5

@openshift-cherrypick-robot

@dislbenn: once the present PR merges, I will cherry-pick it on top of backplane-2.5 in a new PR and assign it to you.

In response to this:

/cherry-pick backplane-2.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Collaborator

@dhaiducek dhaiducek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I have some comments/questions since I was unfamiliar with the settings and took a look at the Renovate docs.

.github/renovate.json Outdated Show resolved Hide resolved
"$schema": "https://docs.renovatebot.com/renovate-schema.json",
"addLabels": ["ok-to-test"],
"rebaseWhen": "behind-base-branch",
"recreateWhen": "never",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this setting is inadvisable:

We recommend that you stick with the default setting for this option. Only change this setting if you really need to.

ref: https://docs.renovatebot.com/configuration-options/#recreatewhen

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After discussing with the team, it seems like the opinion is if we close a PR intentionally then the expected outcome would not to be to reopen the PR. I'm fine with either option; however, I think for now when can test it with the current value that was selected.

.github/renovate.json Outdated Show resolved Hide resolved
.github/renovate.json Outdated Show resolved Hide resolved
.github/renovate.json Outdated Show resolved Hide resolved
Signed-off-by: Disaiah Bennett <[email protected]>
Copy link
Collaborator

@dhaiducek dhaiducek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@openshift-ci openshift-ci bot added the lgtm label Jul 17, 2024
Copy link

openshift-ci bot commented Jul 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhaiducek, dislbenn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit ba308cb into stolostron:main Jul 17, 2024
4 checks passed
@openshift-cherrypick-robot

@dislbenn: new pull request created: #102

In response to this:

/cherry-pick backplane-2.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@dislbenn: new pull request created: #103

In response to this:

/cherry-pick backplane-2.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants