Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ACM-12676] Added renovate config for konflux #97

Merged
merged 2 commits into from
Jul 17, 2024
Merged

[ACM-12676] Added renovate config for konflux #97

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c36575b
added renovate config for konflux
dislbenn Jul 12, 2024
c5f36de
updated renovate.json
dislbenn Jul 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions .github/renovate.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
{
"$schema": "https://docs.renovatebot.com/renovate-schema.json",
"addLabels": ["ok-to-test"],
dislbenn marked this conversation as resolved.
Show resolved Hide resolved
"rebaseWhen": "behind-base-branch",
dislbenn marked this conversation as resolved.
Show resolved Hide resolved
"recreateWhen": "never",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this setting is inadvisable:

We recommend that you stick with the default setting for this option. Only change this setting if you really need to.

ref: https://docs.renovatebot.com/configuration-options/#recreatewhen

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After discussing with the team, it seems like the opinion is if we close a PR intentionally then the expected outcome would not to be to reopen the PR. I'm fine with either option; however, I think for now when can test it with the current value that was selected.

"reviewersFromCodeOwners": true,
dislbenn marked this conversation as resolved.
Show resolved Hide resolved
"rollbackPrs": true,
dislbenn marked this conversation as resolved.
Show resolved Hide resolved
"schedule": ["before 8am on tuesday and thursday"],
"timezone": "America/New_York"
}