Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(v7): get consumer genesis from provider chain and transform it #1093

Merged
merged 1 commit into from
Apr 25, 2024
Merged

refactor(v7): get consumer genesis from provider chain and transform it #1093

merged 1 commit into from
Apr 25, 2024

Conversation

fastfadingviolets
Copy link
Contributor

Summary

Instead of building the ccv genesis for the consumer, we can fetch it from the provider chain. This is preferred, as it guarantees that it works across different consumer/provider versions of ICS

@fastfadingviolets fastfadingviolets requested a review from a team as a code owner April 24, 2024 15:00
@vercel Vercel
Copy link

vercel bot commented Apr 24, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
interchaintest-docs ⬜️ Ignored (Inspect) Visit Preview Apr 24, 2024 5:16pm

@Reecepbcups Reecepbcups mentioned this pull request Apr 24, 2024
Merged
@fastfadingviolets
fix(v7): get consumer genesis from provider chain and transform it
6891854 
This is preferred to building the ccvgenesis ourselves as it guarantees
that it works across different consumer/provider versions of ICS
Reecepbcups
Reecepbcups reviewed Apr 24, 2024
View reviewed changes
examples/ibc/ics_test.go Show resolved Hide resolved
chain/cosmos/chain_node.go Show resolved Hide resolved
chain/cosmos/cosmos_chain.go Show resolved Hide resolved
chain/cosmos/cosmos_chain.go Show resolved Hide resolved
@Reecepbcups
Copy link
Member

This may help me with some of my ICS v5 integration. Will play around with it there as well to understand it better.

@Reecepbcups Reecepbcups changed the title fix(v7): get consumer genesis from provider chain and transform it refactor(v7): get consumer genesis from provider chain and transform it Apr 24, 2024
Reecepbcups added a commit that referenced this pull request Apr 25, 2024
@Reecepbcups
latest ICS v5, impl #1093
497d3f6
@Reecepbcups
Copy link
Member

Reecepbcups commented Apr 25, 2024 •
edited
Loading

This fixed an issue with an older version of neutron I was using originally on the ICS v5 WIP PR. Great work! really appreciated a ton here

This will get backported to main in that PR as well (ref in the commit above)

@Reecepbcups Reecepbcups merged commit 2d9495c into strangelove-ventures:v7 Apr 25, 2024
13 checks passed
@fastfadingviolets fastfadingviolets deleted the fix/v7-ccvgenesis branch April 25, 2024 13:31
Reecepbcups added a commit that referenced this pull request May 6, 2024
@Reecepbcups
feat!: ICS v5 (IBC v8) (#1088)
6682c8c 
* init ICS integration

* feat: ics to local-ic - #989

* IBC not happy

* latest ICS v5, impl #1093

* working ics test

* lint

* fix: `ConsumerAdditionProposalJSON` use trusting period hardcode

* ICS override config versions

* minor nits
@Reecepbcups Reecepbcups mentioned this pull request May 7, 2024
Merged
2 tasks
@mergify mergify bot mentioned this pull request May 8, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Reecepbcups Reecepbcups Reecepbcups approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fastfadingviolets @Reecepbcups