Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed wrong metrics "path" tag by using a custom tags provider #922

Closed
wants to merge 1 commit into from

Conversation

ppatierno
Copy link
Member

This PR is a workaround for #921 to revert back having the HTTP resource path in the path metrics tag instead of the complete URI (even together with the host and query parameters) as used by latest Vert.x versions.
It's also related to the issue vert-x3/vertx-micrometer-metrics#225 I opened on the Vert.x micrometer repo to get why they changed this way.

@ppatierno ppatierno requested a review from scholzj August 5, 2024 10:46
Copy link
Member

@scholzj scholzj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good to me. But ... given we have the bug there since 0.20 -> should we wait for the Vert.x response and if they did it intentionally and not just as a but should we instead adjust our dashboards to Vert.x solution?

@ppatierno
Copy link
Member Author

ppatierno commented Aug 5, 2024

Yeah, I raised the PR just to make people aware of what was going to be a potential workaround.
We can wait for them of course but tbh if they are not going to fix that I am not sure the path tag provided by Vert.x is right. The HTTP resource path has its own meaning and it should not contain host and query parameters. So let's see how the discussion goes with them. My feeling is that they went this way because the commit change also moved from HttpServerRequest to use HttpRequest and this one doesn't expose path() but just uri(). Maybe they just didn't notice the implication of that. I think we should not change our dashboards but fixing the code (with them or by ourselves).

@ppatierno
Copy link
Member Author

As per discussion on #921 I am going to close this PR. We prefer to have it fixed on dashboards or properly by Vert.x folks (still waiting for their answer).

@ppatierno ppatierno closed this Aug 6, 2024
@ppatierno ppatierno deleted the fix-wrong-metrics-path-tag branch August 6, 2024 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants