Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed wrong metrics "path" tag by using a custom tags provider #922

Closed
wants to merge 1 commit into from
Closed

Fixed wrong metrics "path" tag by using a custom tags provider #922

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion src/main/java/io/strimzi/kafka/bridge/Application.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
package io.strimzi.kafka.bridge;

import io.micrometer.core.instrument.MeterRegistry;
import io.micrometer.core.instrument.Tag;
import io.strimzi.kafka.bridge.config.BridgeConfig;
import io.strimzi.kafka.bridge.config.ConfigRetriever;
import io.strimzi.kafka.bridge.http.HttpBridge;
Expand All @@ -14,6 +15,8 @@
import io.vertx.core.Promise;
import io.vertx.core.Vertx;
import io.vertx.core.VertxOptions;
import io.vertx.core.http.impl.Http1xServerRequest;
import io.vertx.core.http.impl.Http2ServerRequest;
import io.vertx.micrometer.Label;
import io.vertx.micrometer.MetricsDomain;
import io.vertx.micrometer.MicrometerMetricsOptions;
Expand All @@ -36,6 +39,7 @@
import java.nio.charset.StandardCharsets;
import java.util.EnumSet;
import java.util.HashSet;
import java.util.List;
import java.util.Map;
import java.util.Set;
import java.util.stream.Collectors;
Expand Down Expand Up @@ -104,7 +108,18 @@ private static MicrometerMetricsOptions metricsOptions() {
// disable metrics about pool and verticles
.setDisabledMetricsCategories(set)
.setJvmMetricsEnabled(true)
.setEnabled(true);
.setEnabled(true)
// using a custom tags provider to overwrite the "path" tag because of https://github.com/vert-x3/vertx-micrometer-metrics/issues/225
// Vert.x seems to use the URI (including host and query parameters) and not just the HTTP resource path anymore
.setServerRequestTagsProvider(req -> {
String path = null;
if (req instanceof Http1xServerRequest) {
path = ((Http1xServerRequest) req).path();
} else if (req instanceof Http2ServerRequest) {
path = ((Http2ServerRequest) req).path();
}
return path != null ? List.of(Tag.of(Label.HTTP_PATH.toString(), path)) : List.of();
});
}

/**
Expand Down
Loading