Skip to content
This repository has been archived by the owner on Oct 20, 2022. It is now read-only.

simplify JdbcProfileProvider by removing "type JP" from base trait #72

Closed
wants to merge 1 commit into from
Closed

simplify JdbcProfileProvider by removing "type JP" from base trait #72

wants to merge 1 commit into from

Conversation

dholbrook
Copy link

Removing the type declaration from JdbcProfileProvider simplifies mixing in the JdbcProfileProvider trait. After the change ActiveSlickWithCodegen no longer has to override the type definition.

@djx314
Copy link
Contributor

djx314 commented Oct 27, 2015

If remove the type JP, any way to access the slick extension when I need to use a specific driver ?
like https://github.com/tminglei/slick-pg
I need to use the type column[JsValue], so I can't use the common JdbcProfile.
See #26

@dholbrook
Copy link
Author

This change caused existing code to break for me and at least one other person see #71

I found a workaround, by override the JP type, but it was non obvious why that was in there, and all the tests pass without it being there. I understand completely if this pr is rejected. It feels like there should be a cleaner solution, but I don't know what that would be.

@octonato
Copy link
Contributor

Sorry that I couldn't react earlier. I had a busy day, too busy.

The JdbcProfileProvider was introduced exactly to make it possible to use alternative drivers, like slick-pg driver.

Therefore, we must maintain the type JP.

@octonato octonato closed this Oct 27, 2015
@octonato
Copy link
Contributor

I'll add more documentation on that to avoid confusion.

@octonato
Copy link
Contributor

Create an issue for it:
#73

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants