Skip to content
This repository has been archived by the owner on Oct 20, 2022. It is now read-only.

simplify JdbcProfileProvider by removing "type JP" from base trait #72

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -4,40 +4,32 @@ import slick.driver.{DerbyDriver, SQLiteDriver, MySQLDriver, HsqldbDriver, Postg


trait JdbcProfileProvider {
type JP <: JdbcProfile
val jdbcProfile: JP
val jdbcProfile: JdbcProfile
}

object JdbcProfileProvider {

trait H2ProfileProvider extends JdbcProfileProvider {
type JP = H2Driver
val jdbcProfile: H2Driver = H2Driver
}

trait PostgresProfileProvider extends JdbcProfileProvider {
type JP = PostgresDriver
val jdbcProfile = PostgresDriver
}


trait DerbyProfileProvider extends JdbcProfileProvider {
type JP = DerbyDriver
val jdbcProfile = DerbyDriver
}

trait HsqlProfileProvider extends JdbcProfileProvider {
type JP = HsqldbDriver
val jdbcProfile = HsqldbDriver
}

trait MySQLProfileProvider extends JdbcProfileProvider {
type JP = MySQLDriver
val jdbcProfile = MySQLDriver
}

trait SQLLiteProfileProvider extends JdbcProfileProvider {
type JP = SQLiteDriver
val jdbcProfile = SQLiteDriver
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ object ActiveSlickWithCodegen {
//
// Implement JdbcProfileProvider with JDBCProfile from generated Tables.scala
//
override type JP = Tables.profile.type
// Sucks that this is necessary. Did we have to define this type in JdbcProfileProvider? Why not just use JdbcProfile?
override val jdbcProfile = Tables.profile

Expand Down