-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
r4ds-style refactor #69
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
maxheld83
modified the milestones:
Jour Fixe DFG,
Konsortien IPOA (>1000) (Beta),
MPDL Test
Feb 10, 2021
This was
linked to
issues
Feb 11, 2021
Closed
This was
linked to
issues
Feb 11, 2021
Closed
This was referenced Feb 16, 2021
Merged
This was
unlinked from
issues
Feb 16, 2021
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before we continue with actual features, we need a bit of refactoring.
This refactoring has a couple of goals; they are so tightly connected that they have to be one, somewhat monolithic refactor unfortunately:
The rmarkdown template (for the mail) strictly should not do any work, but should merely define the presentation of results (i.e. the order of tables and perhaps some commentary).
Among other things, the rmarkdown template currently creates the excel output, which makes this quite brittle (and required the hack-fix for send attachment #44.
No dependencies in rmarkdown templates, in particular, or at least not without programmatically rendereing the template as part of the check.
This thould address, among others: