Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r4ds-style refactor #69

Merged
merged 16 commits into from
Feb 16, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .Rbuildignore
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,4 @@ Dockerfile
^archive$
^data-raw$
.azure/
LICENSE.md
^LICENSE\.md$
5 changes: 2 additions & 3 deletions .github/workflows/main.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ jobs:
shell: Rscript {0}
container:
# update muggle here and in Dockerfile
image: subugoe/muggle-buildtime-onbuild:f7fb6146d8712c4bffb024f4d4f40c40ffab5598
image: subugoe/muggle-buildtime-onbuild:0.1.1-20210126
env:
MUGGLE_PKG_NAME: ${{ github.event.repository.name }}
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
Expand All @@ -32,8 +32,7 @@ jobs:
R_LIBS_SITE: $R_LIBS_RUNTIME_GH
run: remotes::install_deps(dependencies = TRUE)
- name: Check
# TODO error out on all but note again https://github.com/subugoe/hoad/issues/194
run: devtools::check(error_on = "error")
run: devtools::check(error_on = "warning")
- name: Build Package Website
run: |
pkgdown::build_site(override = list(new_process = FALSE))
Expand Down
25 changes: 16 additions & 9 deletions DESCRIPTION
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Package: metacheck
Title: Crossref Metadata Compliance
Version: 0.1.0
Version: 0.1.0.9000
Authors@R:
c(
person(
Expand All @@ -17,6 +17,13 @@ Authors@R:
email = "[email protected]",
comment = c(ORCID = "0000-0002-4703-5388")
),
person(
given = "Henrieke",
family = "Walter",
role = c("aut"),
email = "[email protected]",
comment = c(ORCID = "0000-0003-3313-7364")
),
person(
given = "Göttingen State and University Library",
role = c("cph", "fnd")
Expand All @@ -37,11 +44,11 @@ Authors@R:
Description:
Automatically check metadata compliance for hybrid open access (OA).
Includes a webapp to send compliance reports by email.
License: MIT + file LICENSE
License: AGPL (>= 3)
Encoding: UTF-8
LazyData: true
Roxygen: list(markdown = TRUE)
RoxygenNote: 7.1.1
RoxygenNote: 7.1.1.9999
Imports:
rcrossref,
dplyr,
Expand All @@ -51,7 +58,6 @@ Imports:
blastula,
stringi,
lubridate,
tidyselect,
shiny,
htmltools,
reactable,
Expand All @@ -65,19 +71,20 @@ Imports:
checkmate,
readr,
gluedown,
tibble
tibble,
rmarkdown,
glue,
fs
Suggests:
testthat,
subugoetheme,
shinycaas,
rmarkdown,
bench
shinycaas
URL: https://subugoe.github.io/metacheck, https://github.com/subugoe/metacheck
BugReports: https://github.com/subugoe/metacheck/issues
Remotes:
subugoe/[email protected],
subugoe/[email protected],
subugoe/rcrossref@51d036808c1dc1f46cf1bad1b136e97ad213e162,
rstudio/shinyvalidate@420aec079dbd2c0e12bf8350f4452d105a9cc45c,
subugoe/biblids@d44010e7d0b7d2eef016ef33a05d29e67417dfe6
subugoe/biblids@88735e4146dfefb576ef9558211822f4bb099bec
Config/testthat/edition: 3
2 changes: 1 addition & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
ARG MUGGLE_TAG=f7fb6146d8712c4bffb024f4d4f40c40ffab5598
ARG MUGGLE_TAG=0.1.1-20210126
FROM subugoe/muggle-buildtime-onbuild:${MUGGLE_TAG} as buildtime
FROM subugoe/muggle-runtime-onbuild:${MUGGLE_TAG} as runtime
CMD shinycaas::shiny_opts_az(); metacheck::runMetacheck()
2 changes: 0 additions & 2 deletions LICENSE

This file was deleted.

Loading