Fix copy block and duplicate of form fields #377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-schranz
force-pushed
the
bugfix/copy-block-form
branch
2 times, most recently
from
37fa4ff to
3fa8fe3
Compare
alexander-schranz
changed the title
alexander-schranz
force-pushed
the
bugfix/copy-block-form
branch
from
7f1aecd to
5cab9c6
Compare
alexander-schranz
force-pushed
the
bugfix/copy-block-form
branch
from
5cab9c6 to
6325309
Compare
|
@martinlagler Testcase added! |
|
@alexander-schranz works in our project :) |
martinlagler
reviewed
Jun 6, 2024
martinlagler
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Fix copy block for form manager
Why?
Currently copied field get removed as the same key is copied and key is used to find the field. If now multiple fields with the same key are copied we will ignore the second field and give it a new field.