Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add vm sizing flags to fly pg create #4158

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

add vm sizing flags to fly pg create #4158

wants to merge 1 commit into from

Conversation

rubys
Copy link
Contributor

@rubys rubys commented Jan 8, 2025

No description provided.

@rubys rubys requested a review from davissp14 January 8, 2025 16:13
@davissp14
Copy link
Contributor

Nice. So what happens in the event vm-size is specified along with vm-cpu, vm-memory, etc.?

dangra
dangra reviewed Jan 8, 2025
View reviewed changes
Copy link
Member

@dangra dangra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, please try to reuse the flags and functions to compute the guest from https://github.com/superfly/flyctl/blob/master/internal/flag/machines.go

@rubys rubys marked this pull request as draft January 8, 2025 16:43
@vboginskey vboginskey mentioned this pull request Feb 12, 2025
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dangra dangra dangra left review comments

@davissp14 davissp14 Awaiting requested review from davissp14

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rubys @davissp14 @dangra