feat: Normalise phoneNumber received in the input before processing #881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anku255
changed the title
anku255
force-pushed
the
feat/phone-number-normalisation-api-changes
branch
from
e1c7463 to
6b2657c
Compare
anku255
force-pushed
the
feat/phone-number-normalisation-base
branch
from
15cb479 to
b0fa0dd
Compare
rishabhpoddar
suggested changes
Nov 16, 2023
src/test/java/io/supertokens/test/passwordless/api/PasswordlessCreateCodeAPITest2_11.java
Outdated
Show resolved
Hide resolved
rishabhpoddar
merged commit f93d7e2
into
feat/phone-number-normalisation-base
2 of 3 checks passed
rishabhpoddar
deleted the
feat/phone-number-normalisation-api-changes
branch
This was referenced Nov 20, 2023
rishabhpoddar
pushed a commit
that referenced
this pull request
Nov 20, 2023
… Migration script (#885) * feat: Normalise phoneNumber received in the input before processing (#881) * feat: normalise phoneNumber received in the input before processing * feat: PR changes * feat: PR changes * feat: Improve test for invalid phone number inputs (#884) * feat: Add migration script for phone number normalisation (#882) * feat: Add migration script for phone number normalisation * feat: PR changes * feat: PR changes * feat: PR changes * feat: PR changes * feat: PR changes * feat: PR changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of change
This pull request introduces phone number normalisation to all API endpoints that accept phone numbers as user input. The implementation includes the addition of a
normaliseIfPhoneNumberfunction in theUtilsclass, which is now utilized across all relevant APIs.Related issues
#880
Test Plan
I've added test cases to ensure the proper normalization of phone numbers by the
normaliseIfPhoneNumberutility function. Additionally, I've added corresponding test cases in all modified APIs to validate this behavior.Documentation changes
(If relevant, please create a PR in our docs repo, or create a checklist here
highlighting the necessary changes)
Checklist for important updates
coreDriverInterfaceSupported.jsonfile has been updated (if needed)pluginInterfaceSupported.jsonfile has been updated (if needed)build.gradlegetPaidFeatureStatsfunction in FeatureFlag.java filebuild.gradle, please make sure to add themin
implementationDependencies.json.getValidFieldsinio/supertokens/config/CoreConfig.javaif new aliases were added for any core config (similar to theaccess_token_signing_key_update_intervalconfig alias).git tag) in the formatvX.Y.Z, and then find thelatest branch (
git branch --all) whoseX.Yis greater than the latest released tag.app_id_to_user_idtable, make sure to delete from this table when deleting the user as well ifdeleteUserIdMappingToois false.