-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use DateProvider in EmailVerificationClaim #103
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anku255
changed the title
Use DateProvider in EmailVerificationClaim
fix: use DateProvider in EmailVerificationClaim
Jan 11, 2024
13 tasks
anku255
force-pushed
the
feat/add-date-provider
branch
from
January 12, 2024 06:28
b6d2979
to
c6d00b4
Compare
anku255
force-pushed
the
feat/add-date-provider
branch
from
January 12, 2024 06:31
c6d00b4
to
e4a1534
Compare
porcellus
requested changes
Jan 15, 2024
porcellus
requested changes
Jan 17, 2024
porcellus
approved these changes
Jan 17, 2024
rishabhpoddar
suggested changes
Jan 18, 2024
anku255
commented
Jan 18, 2024
fix: Fix error thrown by Recipe methods when ST is not initialized
rishabhpoddar
suggested changes
Jan 20, 2024
porcellus
requested changes
Jan 22, 2024
porcellus
approved these changes
Jan 23, 2024
rishabhpoddar
suggested changes
Jan 23, 2024
size-limit report 📦
|
rishabhpoddar
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of change
This PR updates the
EmailVerificationClaim
to useDateProvider
to fix clock skew issues.Related issues
Test Plan
(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos!)
Documentation changes
(If relevant, please create a PR in our docs repo, or create a checklist here highlighting the necessary changes)
Checklist for important updates
frontendDriverInterfaceSupported.json
file has been updated (if needed)lib/ts/version.ts
webJsInterfaceSupported.json
file has been updated (if needed)package.json
package-lock.json
lib/ts/version.ts
npm run build-pretty
git tag
) in the formatvX.Y.Z
, and then find the latest branch (git branch --all
) whoseX.Y
is greater than the latest released tag.Remaining TODOs for this PR