Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use DateProvider in EmailVerificationClaim #103

Merged
merged 31 commits into from
Jan 29, 2024

Conversation

anku255
Copy link
Contributor

@anku255 anku255 commented Jan 11, 2024

Summary of change

This PR updates the EmailVerificationClaim to use DateProvider to fix clock skew issues.

Related issues

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos!)

Documentation changes

(If relevant, please create a PR in our docs repo, or create a checklist here highlighting the necessary changes)

Checklist for important updates

  • Changelog has been updated
  • frontendDriverInterfaceSupported.json file has been updated (if needed)
    • Along with the associated array in lib/ts/version.ts
  • webJsInterfaceSupported.json file has been updated (if needed)
  • Changes to the version if needed
    • In package.json
    • In package-lock.json
    • In lib/ts/version.ts
  • Had run npm run build-pretty
  • Had installed and ran the pre-commit hook
  • Issue this PR against the latest non released version branch.
    • To know which one it is, run find the latest released tag (git tag) in the format vX.Y.Z, and then find the latest branch (git branch --all) whose X.Y is greater than the latest released tag.
    • If no such branch exists, then create one from the latest released branch.

Remaining TODOs for this PR

@anku255 anku255 changed the title Use DateProvider in EmailVerificationClaim fix: use DateProvider in EmailVerificationClaim Jan 11, 2024
@anku255 anku255 force-pushed the feat/add-date-provider branch from b6d2979 to c6d00b4 Compare January 12, 2024 06:28
@anku255 anku255 force-pushed the feat/add-date-provider branch from c6d00b4 to e4a1534 Compare January 12, 2024 06:31
test/with-typescript/index.ts Outdated Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
rishabhpoddar and others added 2 commits January 19, 2024 16:27
fix: Fix error thrown by Recipe methods when ST is not initialized
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
lib/ts/recipe/emailverification/emailVerificationClaim.ts Outdated Show resolved Hide resolved
test/unit/init.test.js Show resolved Hide resolved
test/unit/init.test.js Show resolved Hide resolved
Copy link

github-actions bot commented Jan 29, 2024

size-limit report 📦

Path Size
lib/build/index.js 25.95 KB (+4.2% 🔺)
recipe/emailverification/index.js 26.31 KB (+4.48% 🔺)
recipe/emailpassword/index.js 26.04 KB (+3.86% 🔺)
recipe/thirdparty/index.js 27.09 KB (+3.68% 🔺)
recipe/thirdpartyemailpassword/index.js 29.03 KB (+3.43% 🔺)
recipe/session/index.js 23.19 KB (+5.16% 🔺)
recipe/passwordless/index.js 27.36 KB (+3.7% 🔺)
recipe/thirdpartypasswordless/index.js 29.72 KB (+3.94% 🔺)
recipe/userroles/index.js 23.45 KB (+5.13% 🔺)
recipe/multitenancy/index.js 25.69 KB (+4.67% 🔺)

@rishabhpoddar rishabhpoddar merged commit 3cafa4e into 0.8 Jan 29, 2024
4 of 5 checks passed
@rishabhpoddar rishabhpoddar deleted the feat/add-date-provider branch January 29, 2024 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants