fix: use DateProvider in EmailVerificationClaim

CHANGELOG.md

@@ -18,7 +18,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 -   `EmailVerificationClaim` now uses `DateProvider` to account for clock skew.
 -   Exporting the `DateProvider` from supertokens-website, that both built-in and custom validators can use instead of `Date.now` to get an estimate of the server clock.
 -   Added the `dateProvider` prop to the configuration that can be used to customize the built-in `DateProvider`.
--   Added `getClockSkewInMillis` as an overrideable function to the Session recipe that estimates the time difference between the backend and the client.
+-   Added `calculateClockSkewInMillis` as an overrideable function to the Session recipe that estimates the time difference between the backend and the client.
 -   Fix "MultiTenancy not initialized" error being thrown instead of "SuperTokens not initialized" when calling recipe methods directly without initializing SuperTokens first.
 
 ## [0.8.0] - 2023-09-25

lib/ts/recipe/emailverification/emailVerificationClaim.ts

@@ -2,6 +2,10 @@ import { DateProviderReference } from "supertokens-website/utils/dateProvider";
 import { SessionClaimValidator, BooleanClaim } from "../session";
 import { RecipeInterface } from "./types";
 
+function getThresholdAwareDefaultValue(defaultVal: number) {
+    return Math.max(defaultVal, DateProviderReference.getReferenceOrThrow().dateProvider.getThresholdInSeconds());
+}
+
 /**
  * We include "Class" in the class name, because it makes it easier to import/use the right thing (the instance exported by the recipe) instead of this.
  * */
@@ -18,12 +22,15 @@ export class EmailVerificationClaimClass extends BooleanClaim {
 
         this.validators = {
             ...this.validators,
-            isVerified: (refetchTimeOnFalseInSeconds = 10, maxAgeInSeconds = 300) => ({
+            isVerified: (refetchTimeOnFalseInSeconds, maxAgeInSeconds) => ({
                 id: this.id,
                 refresh: this.refresh,
                 shouldRefresh: (payload, userContext) => {
                     const DateProvider = DateProviderReference.getReferenceOrThrow().dateProvider;
 
+                    maxAgeInSeconds = maxAgeInSeconds ?? getThresholdAwareDefaultValue(10);
+                    refetchTimeOnFalseInSeconds = refetchTimeOnFalseInSeconds ?? getThresholdAwareDefaultValue(300);
+
                     if (maxAgeInSeconds < DateProvider.getThresholdInSeconds()) {
                         throw new Error(
                             `maxAgeInSeconds must be greater than the DateProvider threshold value -> ${DateProvider.getThresholdInSeconds()}`

test/with-typescript/index.ts

@@ -837,8 +837,8 @@ function getSessionFunctions(original: SessionRecipeInterface): SessionRecipeInt
         shouldDoInterceptionBasedOnUrl: function (...input) {
             return original.shouldDoInterceptionBasedOnUrl(...input);
         },
-        getClockSkewInMillis: function (input) {
-            return original.getClockSkewInMillis(input);
+        calculateClockSkewInMillis: function (input) {
+            return original.calculateClockSkewInMillis(input);
         },
     };
 }
@@ -1072,6 +1072,7 @@ const cookieHandlerInput: CookieHandlerInput = (original: CookieHandlerInterface
 
 const dateProviderImplementation: DateProviderInterface = {
     getThresholdInSeconds: () => 0,
+    setThresholdInSeconds: () => {},
     getClientClockSkewInMillis: () => 0,
     setClientClockSkewInMillis: () => {},
     now: () => Date.now(),