test: update jest #1792
Merged
test: update jest #1792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TrySound
reviewed
Sep 24, 2023
| "del": "^6.0.0", | ||
| "eslint": "^8.24.0", | ||
| "jest": "^29.1.2", | ||
| "jest": "^29.5.5", |
There was a problem hiding this comment.
You can import from @jest/globals to get types instead of @types/jest
There was a problem hiding this comment.
It's unclear to me how to use @jest/globals properly when the package isn't declared as a module. When I use require, nothing works as expected, and I can't import the types with @typedef. 🤔
Despite this, the tests do pass. I'm just struggling with the TypeScript integration.
There was a problem hiding this comment.
Ah, right. Forgot we don't use ts syntax.
TrySound
approved these changes
Sep 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Locally and on CI the tests sometimes hang at the end, but I don't see any obvious errors in our test suite. 🤔
Before investigating further, I think it'd be best to just update Jest and see how it goes. So far, I've been unable to reproduce the issue with this.