Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: update jest #1792

Merged
merged 1 commit into from
Sep 24, 2023
+557 −372
Merged

test: update jest #1792

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@
},
"eslintConfig": {
"parserOptions": {
"ecmaVersion": "2021"
"ecmaVersion": 2021
},
"env": {
"node": true,
Expand Down Expand Up @@ -122,10 +122,10 @@
"@rollup/plugin-node-resolve": "^14.1.0",
"@types/css-tree": "^2.0.0",
"@types/csso": "^5.0.0",
"@types/jest": "^29.1.1",
"@types/jest": "^29.5.5",
"del": "^6.0.0",
"eslint": "^8.24.0",
"jest": "^29.1.2",
"jest": "^29.5.5",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can import from @jest/globals to get types instead of @types/jest

Copy link
Member Author

@SethFalco SethFalco Sep 24, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's unclear to me how to use @jest/globals properly when the package isn't declared as a module. When I use require, nothing works as expected, and I can't import the types with @typedef. 🤔

Despite this, the tests do pass. I'm just struggling with the TypeScript integration.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, right. Forgot we don't use ts syntax.

"node-fetch": "^2.7.0",
"pixelmatch": "^5.2.1",
"playwright": "^1.14.1",
Expand Down
Loading