Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Mollie v2 API #1133

Merged
merged 11 commits into from
Dec 25, 2024
Merged

Update to Mollie v2 API #1133

merged 11 commits into from
Dec 25, 2024

Conversation

leuke-naam
Copy link
Contributor

Closes #1130

Copy link
Member

@SilasPeters SilasPeters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have not tested it, but damn these changes seem sleek

@stickyPiston
Copy link
Member

I've checked out the changes, but it seems that failed transactions just cause the payment to be restarted. Moreover, the ideal provider button on the payment page in koala doesn't seem to have any effect anymore since it now seems to be included in mollie. Are these issues with the setup i'm testing with or are these implementation errors?

@SilasPeters
Copy link
Member

@leuke-naam could you elaborate?

@leuke-naam leuke-naam changed the title Update to Mollie v3 API Update to Mollie v2 API Dec 16, 2024
@leuke-naam
Copy link
Contributor Author

@leuke-naam could you elaborate?

No

@SilasPeters
Copy link
Member

@leuke-naam I tried to fix the security issue stopping us from deploying, but when testing I get an 401 Unauthorized Request error (Mollie::RequestError in Members::PaymentsController#pay_activities). I assume this is because I am running this from localhost?

Anyway, could you check my latest changes? I am not sure if they work.

@TobiasDeBruijn
Copy link
Member

@leuke-naam I tried to fix the security issue stopping us from deploying, but when testing I get an 401 Unauthorized Request error (Mollie::RequestError in Members::PaymentsController#pay_activities). I assume this is because I am running this from localhost?

Anyway, could you check my latest changes? I am not sure if they work.

@SilasPeters Were you able to solve this?

@SilasPeters
Copy link
Member

No, but @leuke-naam said "looks good, seems to work"

@TobiasDeBruijn
Copy link
Member

Right. @leuke-naam How did you get it to work locally? I haven't had the time to test it out myself, but would like to have it documented for the future.

@SilasPeters
Copy link
Member

@SilasPeters SilasPeters merged commit f372405 into master Dec 25, 2024
1 check passed
@SilasPeters SilasPeters deleted the feat/mollie-v3 branch December 25, 2024 21:04
@TobiasDeBruijn
Copy link
Member

I don't entirely agree with this merge. We still have not got an answer to the question above.

@SilasPeters
Copy link
Member

@TobiasDeBruijn granted, I should have discussed. My philosophy was 'we need to test it on dev anyway'. Also, the solution to the 401 error was using ngrok, and testing on dev was basically that.

Again, should have discussed, but no time for caution

@SilasPeters
Copy link
Member

@leuke-naam @TobiasDeBruijn on dev.svsticky.nl, clicking on pay does not do anything but redirecting to https://koala.dev.svsticky.nl/. Furthermore, somehow all media does not load... Might have to do with me accidentally doing git clean -fdx on the server, but removing everything and redeploying does not fix

@SilasPeters SilasPeters restored the feat/mollie-v3 branch December 25, 2024 21:29
@TobiasDeBruijn
Copy link
Member

@TobiasDeBruijn granted, I should have discussed. My philosophy was 'we need to test it on dev anyway'. Also, the solution to the 401 error was using ngrok, and testing on dev was basically that.

Again, should have discussed, but no time for caution

Neat! Could you document the steps to set up ngrok? Then I'm all happy 😄

@stickyPiston
Copy link
Member

It's good that you mention it! These steps will also need to be documented in undead-mongoose, now that we use mollie there too, and django requires some additional setup to work with ngrok.

@SilasPeters
Copy link
Member

I don't know any concrete steps, nor have I done it. I just remember sem mentioning he needs ngrok to make it work, and I figured the 401 error is because Mollie does not authenticate localhost urls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mollie API deprecation
4 participants