-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to Mollie v2 API #1133
Update to Mollie v2 API #1133
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have not tested it, but damn these changes seem sleek
I've checked out the changes, but it seems that failed transactions just cause the payment to be restarted. Moreover, the ideal provider button on the payment page in koala doesn't seem to have any effect anymore since it now seems to be included in mollie. Are these issues with the setup i'm testing with or are these implementation errors? |
@leuke-naam could you elaborate? |
No |
@leuke-naam I tried to fix the security issue stopping us from deploying, but when testing I get an Anyway, could you check my latest changes? I am not sure if they work. |
@SilasPeters Were you able to solve this? |
No, but @leuke-naam said "looks good, seems to work" |
Right. @leuke-naam How did you get it to work locally? I haven't had the time to test it out myself, but would like to have it documented for the future. |
I don't entirely agree with this merge. We still have not got an answer to the question above. |
@TobiasDeBruijn granted, I should have discussed. My philosophy was 'we need to test it on dev anyway'. Also, the solution to the 401 error was using ngrok, and testing on dev was basically that. Again, should have discussed, but no time for caution |
@leuke-naam @TobiasDeBruijn on dev.svsticky.nl, clicking on pay does not do anything but redirecting to |
Neat! Could you document the steps to set up ngrok? Then I'm all happy 😄 |
It's good that you mention it! These steps will also need to be documented in undead-mongoose, now that we use mollie there too, and django requires some additional setup to work with ngrok. |
I don't know any concrete steps, nor have I done it. I just remember sem mentioning he needs ngrok to make it work, and I figured the 401 error is because Mollie does not authenticate localhost urls |
Closes #1130