-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR4: Add helpmenu option #1628
Merged
shrivaths16
merged 17 commits into
shrivaths/changelog-announcement-3
from
shrivaths/changelog-announcement-4
Jan 19, 2024
Merged
PR4: Add helpmenu option #1628
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
fb0f44e
Add helpmenu option
shrivaths16 fd81643
Merge branch 'shrivaths/changelog-announcement-3' into shrivaths/chan…
shrivaths16 b5980fe
macos pyside2 >=5.12,<=5.15.6
shrivaths16 f8f5fa7
pyside6 >=6 macos
shrivaths16 027c4d6
pyside == 6.2.2.1
shrivaths16 78c30ff
Merge branch 'shrivaths/changelog-announcement-3' into shrivaths/chan…
shrivaths16 0dcd27a
Edit the dhelp menu option
shrivaths16 184e7b8
Merge branch 'shrivaths/changelog-announcement-3' into shrivaths/chan…
shrivaths16 835d3cf
Merge branch 'shrivaths/changelog-announcement-3' into shrivaths/chan…
shrivaths16 59db054
Merge branch 'shrivaths/changelog-announcement-3' into shrivaths/chan…
shrivaths16 e800037
Merge branch 'shrivaths/changelog-announcement-3' into shrivaths/chan…
shrivaths16 48bf57e
Merge branch 'shrivaths/changelog-announcement-3' into shrivaths/chan…
shrivaths16 52d137d
Merge branch 'shrivaths/changelog-announcement-3' into shrivaths/chan…
shrivaths16 ddd74cc
Merge branch 'shrivaths/changelog-announcement-3' into shrivaths/chan…
shrivaths16 ac4fced
Merge branch 'shrivaths/changelog-announcement-3' into shrivaths/chan…
shrivaths16 8d96262
Merge branch 'shrivaths/changelog-announcement-3' into shrivaths/chan…
shrivaths16 4b51812
Merge branch 'shrivaths/changelog-announcement-3' into shrivaths/chan…
shrivaths16 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's good to see the addition of a "What's New?" action to the help menu. To ensure robustness, consider verifying that
self.commands.showBulletin
is callable before adding it to the action. This can prevent potential runtime errors if the method is not defined or incorrectly implemented.