-
-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add set_badge_count
for Linux, iOS; set_badge_label
for Macos; set_overlay_icon
for Windows
#1002
Conversation
Package Changes Through f84c710There are 1 changes which include tao with patch Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
Fixing the macos and linux code issues... |
set_badge_count
for Linux and Macos; set_overlay_icon
for Windowsset_badge_count
for Linux; set_badge_label
for Macos; set_overlay_icon
for Windows
What do we do about these warnings (linux)?
|
set_badge_count
for Linux; set_badge_label
for Macos; set_overlay_icon
for Windowsset_badge_count
for Linux, iOS; set_badge_label
for Macos; set_overlay_icon
for Windows
Somehow it auto fixed idk how and why. Found why: the window needs to have an icon set for some reason? |
@amrbashir Why is the Icon struct needed to be cloned inside the set_overlay_icon function? |
nvm fixed it, Basically the Icon has to be borrowed for some unknown reason |
otherwise, it will be dropped and freeed |
No issue, I made it to accept a borrowed Icon |
there is also a missing import for macOS, not sure why iOS is failing though |
I have no idea either |
Both the examples under cfg of macos and ios are not applying. Do you have any idea why? |
That commit should be it |
Thank you |
Thanks a lot, I shall also PR to tauri crate to attach those apis to the tauri app |
@amrbashir We'll implement the overlay label for Windows under a feature in the main tauri crate (it'll need the image crate, ab_glyph and imageproc crate as pointed out by @retrouser955 to me) |
we already depend on |
Sure ! I shall work on a PR tomorrow |
This is a step further to implement tauri-apps/tauri#4489 into the main tauri crate