Add Clang 19 to CI test matrices #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcbrindle
force-pushed
the
pr/add_clang19
branch
from
bf9fbad
to
a298e22
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #215 +/- ##
=======================================
Coverage ? 98.61%
=======================================
Files ? 69
Lines ? 2608
Branches ? 0
=======================================
Hits ? 2572
Misses ? 36
Partials ? 0 ☔ View full report in Codecov by Sentry. |
I'm not quite sure what's changed with Clang 19, but it's suddenly complaining about libstdc++12's `variant` using the non-active member of a union in constexpr. It's possible there was such a bug in libstdc++12, but it seems weird that it wasn't picked up by either GCC12 or an older version of Clang... Anyway, hopefully this will fix it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.