Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Clang 19 to CI test matrices #215

Merged
merged 3 commits into from
Nov 5, 2024
Merged

Add Clang 19 to CI test matrices #215

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d8b6768
Add LLVM Clang 19 to MacOS test matrix
tcbrindle Nov 5, 2024
a298e22
Add Clang 19 to Linux test matrix
tcbrindle Nov 5, 2024
e20f432
Fix variant emplace with Clang19/libstdc++
tcbrindle Nov 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion .github/workflows/linux.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
compiler: [GCC-11, GCC-12, GCC-13, GCC-14, Clang-17, Clang-18]
compiler: [GCC-11, GCC-12, GCC-13, GCC-14, Clang-17, Clang-18, Clang-19]
test_with: [Headers, Module]
build_type: [Debug, Release]

Expand Down Expand Up @@ -56,6 +56,11 @@ jobs:
install: |
brew install llvm@18 ninja binutils
brew link --force binutils
- compiler: Clang-19
cxx: $(brew --prefix llvm@19)/bin/clang++
install: |
brew install llvm@19 ninja binutils
brew link --force binutils

steps:
- uses: actions/checkout@master
Expand Down
6 changes: 5 additions & 1 deletion .github/workflows/macos.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
runs-on: macos-latest
strategy:
matrix:
compiler: [GCC-13, LLVM-Clang-16, LLVM-Clang-17, LLVM-Clang-18]
compiler: [GCC-13, LLVM-Clang-16, LLVM-Clang-17, LLVM-Clang-18, LLVM-Clang-19]
test_with: [Headers, Module]
build_type: [Debug, Release]

Expand Down Expand Up @@ -42,6 +42,10 @@ jobs:
cxx: $(brew --prefix llvm@18)/bin/clang++
install: |
brew install llvm@18 ninja
- compiler: LLVM-Clang-19
cxx: $(brew --prefix llvm@19)/bin/clang++
install: |
brew install llvm@19 ninja


steps:
Expand Down
10 changes: 3 additions & 7 deletions include/flux/adaptor/flatten_with.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,14 +19,10 @@ namespace detail {
template <std::size_t N>
inline constexpr auto variant_emplace =
[]<typename... Types>(std::variant<Types...>& variant, auto&&... args) {
if constexpr (__cpp_lib_variant >= 202106L) {
variant.template emplace<N>(FLUX_FWD(args)...);
if (std::is_constant_evaluated()) {
variant = std::variant<Types...>(std::in_place_index<N>, FLUX_FWD(args)...); // LCOV_EXCL_LINE
} else {
if (std::is_constant_evaluated()) {
variant = std::variant<Types...>(std::in_place_index<N>, FLUX_FWD(args)...); // LCOV_EXCL_LINE
} else {
variant.template emplace<N>(FLUX_FWD(args)...);
}
variant.template emplace<N>(FLUX_FWD(args)...);
}
};

Expand Down