Fixed the design issue with the footer #287
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I was thinking more about the asymmetry you see in the picture, although I agree this is also an improvement. We may need to work with margins or something. |
|
I understand what you are talking about, but by separating them i dont see it as a problem anymore? Perhaps we can look into a redesign in the future:) |
…est of the bottom
otytlandsvik
requested changes
Jun 3, 2024
src/theme.ts
Outdated
| @@ -23,6 +23,7 @@ const theme = extendTheme( | |||
| td: '#C7323A' /* TD red */, | |||
| }, | |||
| primary: '#ffffff', | |||
| darkerBackground: '#11131d', | |||
There was a problem hiding this comment.
This darker background color would be part of our slate palette, on the next line. Add it there instead under the 900 key.
| w="100%" | ||
| direction={{ base: 'column', lg: 'row' }} | ||
| mt="auto"> | ||
| mt="auto" | ||
| style={{ background: theme.colors.darkerBackground, paddingTop: '2rem' }}> |
There was a problem hiding this comment.
For chakra-ui components use the chakra color prop instead.
…frontend into feature/footerStyle Fixed the footer design probem
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💎 Changes
Closes [#277]
Use a list to express the changes if there are multiple: