Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the design issue with the footer #287

Closed
wants to merge 8 commits into from
Closed

Fixed the design issue with the footer #287

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
f952120
added color to the background in the footer
Keyvan0111 Jun 2, 2024
98e8d85
Made the color as a theme variable for consistency
Keyvan0111 Jun 2, 2024
1d37e2d
run prettier for formatting
Keyvan0111 Jun 2, 2024
9b54010
fix the bug where the bottom of footer does not extend thropugh the r…
Keyvan0111 Jun 3, 2024
8a03126
Add darker bgcolor for the footer to separate it from the rest of the…
Keyvan0111 Jun 3, 2024
988121a
Add darker bgcolor for the footer to separate it from the rest of the…
Keyvan0111 Jun 3, 2024
8fcface
Add darker bgcolor for the footer to separate it from the rest of the…
Keyvan0111 Jun 3, 2024
23181d6
Merge branch 'feature/footerStyle' of github.com:td-org-uit-no/tdctl-…
Keyvan0111 Jun 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/components/molecules/footer/Footer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import {
Heading,
Flex,
} from '@chakra-ui/react';

import theme from '../../../theme';
interface FooterListProps {
header: string;
children?: React.ReactNode;
Expand Down Expand Up @@ -85,10 +85,12 @@ const Footer: React.FC = () => {
// uses margin auto, needs parent page to have minHeight=100vh if content is not over 100vh
return (
<Flex
my="2rem"
my="0rem"
w="100%"
direction={{ base: 'column', lg: 'row' }}
mt="auto">
mt="auto"
bgColor="slate.900"
style={{ paddingTop: '2rem' }}>
<Flex justify="space-evenly" width={{ base: '100%', lg: '60%' }}>
<FooterList header={'Ressurser'}>
<FooterItem label={'Om TD'} path={'/about-us'} />
Expand Down
1 change: 1 addition & 0 deletions src/theme.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ const theme = extendTheme(
600: '#2b2c3d',
700: '#1b1e2c',
800: '#161926',
900: '#11131d',
},
secondary: '#f8d2cc',
inputBackground: '#272530',
Expand Down
Loading